RFR: 8295867: TestVerifyGraphEdges.java fails with exit code -1073741571 when using AlwaysIncrementalInline [v2]

Christian Hagedorn chagedorn at openjdk.org
Fri Nov 11 09:42:24 UTC 2022


On Thu, 10 Nov 2022 16:26:13 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 4243:
>> 
>>> 4241:     // Allocate stack of size C->live_nodes()/16 to avoid frequent realloc
>>> 4242:     uint stack_size = live_nodes() >> 4;
>>> 4243:     Node_List nstack(MAX2(stack_size, (uint)OptoNodeListSize));
>> 
>> As you only need the stack in `verify_edges()`, I suggest to move these lines directly into the method `verify_edges()`.
>
> I need `live_nodes()` value or `stack_size` or `C` to pass for creating list inside method.
> I decided to move renamed `verify_bidirectional_edges()` method to `Compile` class to get these values inside the method.
> It does not need to be in `Node` class after I removed recursion.

Right, I've missed that before. Moving it to `Compile` is a good idea to apply that!

-------------

PR: https://git.openjdk.org/jdk/pull/11065


More information about the hotspot-compiler-dev mailing list