RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v14]

Vladimir Ivanov vlivanov at openjdk.org
Fri Nov 11 20:01:34 UTC 2022


On Fri, 11 Nov 2022 18:08:50 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 733:
>> 
>>> 731:   void andptr(Register src1, Register src2) { LP64_ONLY(andq(src1, src2)) NOT_LP64(andl(src1, src2)) ; }
>>> 732: 
>>> 733: #ifdef _LP64
>> 
>> Why is it x64-specific?
>
> I believe its needed.
> 
> TLDR.. Couple of check ins ago, I broke the 32-bit build, and that was the 'easy' fix..

Right, `addq` instructions are x64-specific. I was confused because `assembler_x86.hpp` doesn't declare them as such which is a bug.

-------------

PR: https://git.openjdk.org/jdk/pull/10582


More information about the hotspot-compiler-dev mailing list