RFR: JDK-8295934: IGV: keep node selection when changing view or graph [v4]

[Tobias Holenstein]

On Mon, 14 Nov 2022 09:54:00 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Keeping the user's node selection across views and related graphs is a useful enhancement, thanks!
> 
> As a user, I only have an objection to selecting the Root node when opening a new graph without a previous selection: I would rather not select any node in that situation. Selecting the Root node forces the attention of the user to an arbitrary part of the graph, and this node is not relevant to all views, e.g. the CFG view of the current "Final Code" graph.
> 
> Regarding the code changes, I think it would be better for ease of reviewing and traceability to leave cleanups and unrelated refactorings (such as removal of unused imports in `GraphViewerImplementation.java` or not passing a `SceneAnimator` to `LineWidget.java`) to separate RFEs.

Hi @robcasloz 
Thanks for your comment! 
I agree that the root not should not be selected. I changed the PR accordingly: now the root node is only centered but not selected anymore. 

I also agree that import of untouched files should not be touches. I reverted that. 

The `SceneAnimator` in `LineWidget.java` was removed because in order to implement this PR I had to refactor the `processOutputSlot()` method which is the only place there `LineWidget.java` is initiated.

-------------

PR: https://git.openjdk.org/jdk/pull/11062