RFR: 8295698: AArch64: test/jdk/sun/security/ec/ed/EdDSATest.java failed with -XX:+UseSHA3Intrinsics

[Andrew Haley]

On Mon, 14 Nov 2022 11:46:57 GMT, Dong Bo <dongbo at openjdk.org> wrote:

> > This looks right, but I don't think I can test it, which I usually would do with a patch this complicated. When we have a processor without FEAT_SHA3) we should define BCAX, EOR3, RAX1, and XAR as macros. Could you do that, please?
> 
> Thanks for the comments.
> 
> Do you mean that we need a patch (not to be merged) to support testing on processor without FEAT_SHA3? In which, the SHA3 instructions are substituted by multiple instructions, something like: `eor3 v1, v2, v3, v4 => eor v1, v2, v3; eor v1, v1, v4`?

Yes, exactly. So the intrinsic will work everywhere. Why not merge it? It seems obvious to me.

> BTW, FEAT_SHA3 is supported on M1. If you happen to have one, the test can be done on it. :) To test this on M1/MacOS, modification below is needed to enable SHA3Intriniscs by default. Since other features, i.e. UseSHA, can not be automatically detected neither, I think it is irrelevant with this patch.

Do you know why SHA3 isn't enabled on M1?

-------------

PR: https://git.openjdk.org/jdk/pull/10939