RFR: 8286302: Port JEP 425 to PPC64 [v3]

Richard Reingruber rrich at openjdk.org
Wed Nov 16 10:24:30 UTC 2022


On Wed, 16 Nov 2022 08:42:34 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Fix cpp condition and add PPC64
>>  - Changes lost in merge
>>  - Merge branch 'master' into 8286302_Port_JEP_425_to_PPC64
>>  - Use callers_sp for fsize calculation in recurse_freeze_interpreted_frame
>>  - Loom ppc64le port
>
> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 201:
> 
>> 199:             // compLevel = CompilerWhiteBoxTest.COMP_LEVEL_FULL_PROFILE;
>> 200: 
>> 201:             compPolicySelection =  Integer.parseInt(args[0]);
> 
> nit
> Suggestion:
> 
>             compPolicySelection = Integer.parseInt(args[0]);

Done

> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 341:
> 
>> 339: 
>> 340:         public boolean shiftWindow() {
>> 341:             if(compWindowMode == CompWindowMode.NO_COMP_WINDOW) return false;
> 
> nit
> Suggestion:
> 
>             if (compWindowMode == CompWindowMode.NO_COMP_WINDOW) return false;

Done

> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 483:
> 
>> 481:                 try {
>> 482:                     cont.run();
>> 483:                 } catch(UnhandledException e) {
> 
> nit
> Suggestion:
> 
>                 } catch (UnhandledException e) {

Done. Thanks for looking at the PR!

-------------

PR: https://git.openjdk.org/jdk/pull/10961


More information about the hotspot-compiler-dev mailing list