RFR: JDK-8297047: IGV: graphContent not set when opening a new tab

Tobias Holenstein tholenstein at openjdk.org
Wed Nov 16 13:52:58 UTC 2022


On Tue, 15 Nov 2022 16:47:36 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Open any graph in IGV. The graph will be opened in a new tab as expected. But the tab has the name "graph" instead of the actual graph name. Further, the "Bytecode" and "Control Flow" windows are not updated with the current graph. 
>> 
>> The reason was that `graphContent` was not set when opening a new EditorTopComponent.
>> 
>> Before: 
>> ![graph_not_updated](https://user-images.githubusercontent.com/71546117/201946772-727f1c57-d69e-4551-a560-14d18cfb2b63.png)
>> 
>> Now the title of tab and the "Control Flow" is updated:
>> ![graph_updated](https://user-images.githubusercontent.com/71546117/201947659-a238d0a2-b064-4373-81dc-7fb3f0dea7ec.png)
>
> Looks good!

Thanks @chhagedorn and @robcasloz for the reviews!

-------------

PR: https://git.openjdk.org/jdk/pull/11168


More information about the hotspot-compiler-dev mailing list