RFR: JDK-8297032: IGV: shortcut to center selected nodes [v2]

Tobias Holenstein tholenstein at openjdk.org
Wed Nov 16 15:07:03 UTC 2022


On Tue, 15 Nov 2022 18:27:50 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Looks good to me! A nit (up to you whether you want to address it in this PR): you might disable the action when no node is selected, similarly to the node extraction action.

Thanks for the good input @robcasloz ! 

I addressed your suggestion by making `CenterSelectedNodesAction` a `ModelAwareAction` and overriding the `isEnabled()` function: The action is now disabled if no nodes are selected

-------------

PR: https://git.openjdk.org/jdk/pull/11167


More information about the hotspot-compiler-dev mailing list