RFR: 8297238: RISC-V: Unifying predicates for vector type matching in c2
Fei Yang
fyang at openjdk.org
Sat Nov 19 08:39:32 UTC 2022
On Fri, 18 Nov 2022 13:12:54 GMT, Gui Cao <gcao at openjdk.org> wrote:
> Hi,
>
> In the vector type predicate matching process of riscv, n->bottom_type()->is_vect()->element_basic_type() is used in some places to get the data type, and Matcher::vector_element_basic_type(n) is used in some places to get the data type, In fact, Matcher::vector_element_basic_type(n) is the function encapsulation form of n->bottom_type()->is_vect()->element_basic_type(), here Matcher::vector_element_basic_type(n) is used uniformly to get the data type.
>
> Please take a look and have some reviews. Thanks a lot.
>
> ## Testing:
> - hotspot and jdk tier1 without new failures (release with UseRVV on QEMU)
> - test/jdk/jdk/incubator/vector/* (fastdebug/release with UseRVV on QEMU)
PS: I think it should be more specific to change the title of the JBS issue to something like: "RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate"
-------------
PR: https://git.openjdk.org/jdk/pull/11239
More information about the hotspot-compiler-dev
mailing list