RFR: 8297384: Add IR tests for existing idealizations of arithmetic nodes [v3]

Christian Hagedorn chagedorn at openjdk.org
Wed Nov 23 09:06:24 UTC 2022


On Tue, 22 Nov 2022 17:32:51 GMT, Zhiqiang Zang <duke at openjdk.org> wrote:

>> I noticed some idealizations have no associated IR tests so I included for them.
>
> Zhiqiang Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge master.
>  - include @bug and @summary for newly created ir test classes.
>  - format.
>  - format whitespace.
>  - add some missing tests for existing idealizations.

We should make sure to make them pass on x86 as well such that GHA is clean after the integration of this PR. I've had a quick look on the match rules and it seems that we only use `RotateLeft/Right` nodes on x86_64, aarch64 and riscv. We could restrict these tests to only run on these architectures with  `@requires os.arch == "x86_64" | os.arch == "aarch64"  | os.arch == "riscv64"`.

-------------

PR: https://git.openjdk.org/jdk/pull/11049


More information about the hotspot-compiler-dev mailing list