RFR: 8297417: Poly1305IntrinsicFuzzTest fails with tag mismatch exception [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Nov 24 08:24:22 UTC 2022


On Wed, 23 Nov 2022 22:50:34 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:

>> From https://github.com/openjdk/jdk/pull/10582, `t0` gets clobbered if `rscratch` is used. Example, [here](https://github.com/openjdk/jdk/blob/09f70dad2fe3f0691afacded6c38f61fa8a0d28d/src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp#L605-L606): 
>> 
>> 
>>   __ mov(t0, a0);
>>   __ andq(t0, ExternalAddress(poly1305_mask44()), rscratch); // First limb (R^4[43:0])
>
> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add UnlockDiagnosticVMOptions

Thanks for promptly addressing this issue, Volodymyr, looks good. I see that @iwanowww's internal testing succeeded.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11308


More information about the hotspot-compiler-dev mailing list