RFR: 8297556: Parse::check_interpreter_type fails with assert "must constrain OSR typestate"

Tobias Hartmann thartmann at openjdk.org
Thu Nov 24 15:45:24 UTC 2022


On Thu, 24 Nov 2022 15:20:27 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> With 6312651 (Compiler should only use verified interface types for
> optimization), I changed when the _klass field for an array in the
> type system would be null. Before, there was an assumption that any
> type (other than top, bottom) could be represented with a non null
> _klass field. With 6312651, there are types that are impossible to
> represent with a single klass pointer so now, the _klass field is only
> guaranteed non null for an array of basic type. When I made that
> change, I went over uses of the _klass field for anything other than
> an array of basic type and fixed the code so it uses something other
> than the _klass field. This is a place I missed.
> 
> (I made some of the changes for the _klass field after Vladimir I ran
> extensive testing for the patch so that could explain why this issue
> was missed)

Looks good to me. All tests passed.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11356


More information about the hotspot-compiler-dev mailing list