Integrated: 8297343: TestStress*.java fail with "got different traces for the same seed"
Roland Westrelin
roland at openjdk.org
Mon Nov 28 12:30:24 UTC 2022
On Thu, 24 Nov 2022 15:27:41 GMT, Roland Westrelin <roland at openjdk.org> wrote:
> Root cause from Roberto's analysis:
>
> "The regression seems to be due to the introduction of non-determinism
> in the node dumps of otherwise identical compilations."
>
> "The problem seems to be that JDK-6312651 dumps interface sets in an
> order that is determined by the raw pointers of the set elements. This
> is unstable across different runs and leads to different node dumps
> for otherwise identical compilations."
>
> "Stable node dumps are useful for debugging (e.g. when diffing
> compiler traces from two different runs), so the solution is probably
> dumping interface sets in some order (e.g. lexicographic order of each
> interface dump) that does not depend on raw pointer values."
>
> This patch implements Roberto's recommendation by sorting interfaces
> on their ciBaseObject::_ident.
This pull request has now been integrated.
Changeset: eff4c039
Author: Roland Westrelin <roland at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/eff4c039dab99aa946dbdde1be8901929ebbfc6f
Stats: 14 lines in 2 files changed: 9 ins; 3 del; 2 mod
8297343: TestStress*.java fail with "got different traces for the same seed"
Reviewed-by: thartmann, chagedorn
-------------
PR: https://git.openjdk.org/jdk/pull/11357
More information about the hotspot-compiler-dev
mailing list