RFR: JDK-8294567: IGV: IllegalStateException in search

Tobias Holenstein tholenstein at openjdk.org
Mon Oct 3 07:17:53 UTC 2022


On Thu, 29 Sep 2022 10:18:56 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> When searching for a node, IGV first looks in the current open graph. If it can find the node here everything works fine. 
>> 
>> # Problem
>> If if cannot find the node if uses the `searchForward` and `searchBackward` in the `EditorInputGraphProvider` to search in the other graphs. It crashes here because `editor.isOpened()` can only be called from the `EventDispatchThread`
>> 
>> # Solution
>> The calls to `editor.isOpened()` are not needed because `editor != null` already means that it is open. So just remove all 4 calls to `editor.isOpened()`.
>
> Looks good!

Thanks you @robcasloz , @chhagedorn and @vnkozlov for the reviews!

-------------

PR: https://git.openjdk.org/jdk/pull/10483


More information about the hotspot-compiler-dev mailing list