RFR: JDK-8294529 : IGV: Highlight the current graphs in the Outline [v2]

Tobias Holenstein tholenstein at openjdk.org
Mon Oct 3 11:35:15 UTC 2022


On Fri, 30 Sep 2022 10:36:16 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   escapeHTML in  getHtmlDisplayName()
>
> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/FolderNode.java line 140:
> 
>> 138:     }
>> 139: 
>> 140:     private boolean selected = false;
> 
> You should move this field up to the other field declarations.

done

> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/GraphNode.java line 63:
> 
>> 61:     }
>> 62: 
>> 63:     private boolean selected = false;
> 
> You should move this field up to the other field declarations.

done

> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/OutlineTopComponent.java line 229:
> 
>> 227: 
>> 228:     private GraphNode[] selectedGraphs = new GraphNode[0];
>> 229:     private final Set<FolderNode> selectedFolders = new HashSet<>();
> 
> You should move these fields up to the other field declarations.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10468


More information about the hotspot-compiler-dev mailing list