RFR: JDK-8294564: IGV: IllegalArgumentException for "Difference to current graph" [v3]

Tobias Holenstein tholenstein at openjdk.org
Mon Oct 3 14:38:39 UTC 2022


On Mon, 3 Oct 2022 14:13:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - split lines
>>  - remove empty line
>
> src/utils/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/InputGraph.java line 42:
> 
>> 40:     private Map<Integer, InputBlock> nodeToBlock;
>> 41:     private boolean isDiffGraph;
>> 42:     private InputGraph firstGraph, secondGraph;
> 
> Can be made `final`. I would also split this line into two lines.

I split it into two lines. They can not be final because the constructor `InputGraph(InputGraph firstGraph, InputGraph secondGraph)` calls the second constructor `InputGraph(String name)` and both assign `firstGraph` and  `secondGraph`

-------------

PR: https://git.openjdk.org/jdk/pull/10533


More information about the hotspot-compiler-dev mailing list