Maybe set -XX:+VerifyContinuations in tests?

[Reingruber, Richard]

> On 10/5/22 11:59, Reingruber, Richard wrote:
> > would it make sense to set -XX:+VerifyContinuations for all tests in
> > test/jdk/jdk/internal/vm/Continuation/?

> In my experience, this would make the test rather long, so I'd rather avoid this.

I've tested Fuzz.java#default with fastdebug. Durations varied quite a bit:

-XX:-VerifyContinuations (default)
Minimum duration: 1m35s
Maximum duration: 2m13s

-XX:+VerifyContinuations
Minimum duration: 2m14s
Maximum duration: 3m48s

on an older "Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz"

Maybe it would be ok to just set it for Fuzz.java#default.

On the other hand it is probably sufficient to have dedicated runs with -XX:+VerifyContinuations.

> > Is exporting _JAVA_OPTIONS=-XX:+VerifyContinuations the only way to do it now?

> The usual way is to pass options to "make test":

> $ make test TEST="jdk_loom hotspot_loom" TEST_VM_OPTS="-XX:+VerifyContinuations"

Right, thanks.
I was confused and assumed that this wouldn't work with the `/othervm` option
(even though I used it myself a while ago to change gc).

Thanks, Richard.

________________________________
From: Aleksey Shipilev <shade at redhat.com>
Sent: Wednesday, October 5, 2022 12:20
To: Reingruber, Richard <richard.reingruber at sap.com>; hotspot-compiler-dev at openjdk.java.net <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: Maybe set -XX:+VerifyContinuations in tests?

On 10/5/22 11:59, Reingruber, Richard wrote:
> would it make sense to set -XX:+VerifyContinuations for all tests in
> test/jdk/jdk/internal/vm/Continuation/?

In my experience, this would make the test rather long, so I'd rather avoid this.

> Is exporting _JAVA_OPTIONS=-XX:+VerifyContinuations the only way to do it now?

The usual way is to pass options to "make test":

$ make test TEST="jdk_loom hotspot_loom" TEST_VM_OPTS="-XX:+VerifyContinuations"

--
Thanks,
-Aleksey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-compiler-dev/attachments/20221005/74432f9d/attachment-0001.htm>