RFR: 8283699: Improve the peephole mechanism of hotspot [v4]

Quan Anh Mai qamai at openjdk.org
Fri Oct 7 15:11:24 UTC 2022


On Thu, 6 Oct 2022 21:33:38 GMT, Dean Long <dlong at openjdk.org> wrote:

>> `opto/peephole.hpp` is needed from the generated `ad_x86_peephole.cpp` so that `addI_rRegNode::peephole` can call the helper functions.
>
> How about including `peephole_<cpu>.hpp` only when "peepprocedure" is seen, and delete opto/peephole.hpp and empty `peephole_<cpu>.hpp` files?

What do you think if I include `peephole_x86.hpp` in `x86_64.ad` in a source hpp block? This will result in the include appearing in `ad_x86.hpp`, which will be transitively included in `ad_x86_peephole.cpp`. Thanks a lot.

-------------

PR: https://git.openjdk.org/jdk/pull/8025


More information about the hotspot-compiler-dev mailing list