RFR: 8283699: Improve the peephole mechanism of hotspot [v4]
Vladimir Ivanov
vlivanov at openjdk.org
Fri Oct 7 20:27:20 UTC 2022
On Fri, 7 Oct 2022 20:07:27 GMT, Dean Long <dlong at openjdk.org> wrote:
>> What do you think if I include `peephole_x86.hpp` in `x86_64.ad` in a source hpp block? This will result in the include appearing in `ad_x86.hpp`, which will be transitively included in `ad_x86_peephole.cpp`. Thanks a lot.
>
> Yes, good idea.
Considering `peephole_x86.cpp` contains only x64-specific code, I had a suggestion to rename it into `peephole_x86_64.cpp` and move `#ifdef _LP64` into `peephole_x86.hpp` to guard x64-specific declarations. But if you intend to include the header directly from `x86_64.ad`, you can rename the header to `peephole_x86_64.hpp` and get rid of `#ifdef _LP64` completely.
-------------
PR: https://git.openjdk.org/jdk/pull/8025
More information about the hotspot-compiler-dev
mailing list