RFR: 8292898: [vectorapi] Unify vector mask cast operation [v5]

[Jatin Bhateja]

On Tue, 4 Oct 2022 06:05:27 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi @XiaohongGong , Thanks!,  changes looks good to me, an IR framework test will complement the patch.
>
>> Hi @jatin-bhateja , the IR test has been added. Could you please help to review again? Thanks a lot!
> 
> Some of the IR tests like testByte64ToLong512 are currently are failing on KNL due to following check 
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L2484
> 
> since source and destination ideal types are different (TypeVect vs TypeVectMask),  can you kindly change the feature check for relevant IR tests to avx512vl  till we remove that limitation.

> > > > Hi @jatin-bhateja , the IR test has been added. Could you please help to review again? Thanks a lot!
> > > 
> > > 
> > > Some of the IR tests like testByte64ToLong512 are currently are failing on KNL due to following check https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L2484
> > > since source and destination ideal types are different (TypeVect vs TypeVectMask), can you kindly change the feature check for relevant IR tests to avx512vl till we remove that limitation.
> > 
> > 
> > Thanks for pointing out this issue. Sure, I will limit the feature check to "avx512vl" for all the 512 bits related casting. BTW, could you please show me how to run the test with KNL feature? So that I can have an internal test before pushing the changes. Thanks a lot!
> 
> Hi @jatin-bhateja , the test is updated. I tested it with `-XX:+UseKNLSetting` by adding the flag to 
`TestFramework.runWithFlags()` in the main function, and tests pass. Could you please help to check whether it is ok for you? 
Thanks!, we can also pass additional flag in JTREG_WHITELIST_FLAGS in TestFramework.java
Thanks a lot!

Hi @XiaohongGong , Thanks for addressing my comments, test now passes on KNL platform. 
Newly introduced @Warmup annotation in all the tests looks redundant since in NORMAL run-mode framework does the necessary warmup followed by compilation by "C2' (default compiler).

-------------

PR: https://git.openjdk.org/jdk/pull/10192