RFR: 8288043: Optimize FP to word/sub-word integral type conversion on X86 AVX2 platforms [v7]

Jatin Bhateja jbhateja at openjdk.org
Mon Oct 10 17:16:51 UTC 2022


On Sat, 1 Oct 2022 00:28:16 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8288043: Adding descriptive comments.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4611:
> 
>> 4609: void C2_MacroAssembler::vector_castF2L_evex(XMMRegister dst, XMMRegister src, XMMRegister xtmp1, XMMRegister xtmp2,
>> 4610:                                             KRegister ktmp1, KRegister ktmp2, AddressLiteral double_sign_flip,
>> 4611:                                             Register rscratch, int vec_enc) {
> 
> Need an assert here:
> assert(rscratch != noreg || always_reachable(double_sign_flip), "missing");

Hi @sviswa7, assertions are part of leaf level macro assembly routine which is vector_cast_float_to_long_special_cases_evex in this case.

-------------

PR: https://git.openjdk.org/jdk/pull/9748


More information about the hotspot-compiler-dev mailing list