Integrated: 8294356: IGV: scheduled graphs contain duplicated elements

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Oct 11 07:15:28 UTC 2022


On Mon, 26 Sep 2022 13:55:56 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This changeset removes duplicated nodes and edges from graph dumps that include a control-flow graph:
> ![cfg-before-after](https://user-images.githubusercontent.com/8792647/192294554-73ca3927-dab3-4d8f-9503-0904a4da7434.png)
> This is achieved by ensuring that HotSpot only visits each node once when dumping IGV graphs.
> 
> #### Testing
> - Tested that tens of thousands of graphs do not contain duplicated nodes or edges by instrumenting IGV and running `java -Xcomp -XX:PrintIdealGraphLevel=4`.
> - Tested manually that unscheduled graphs are not affected by this changeset.
> - Tested that running compiler tests with `-XX:PrintIdealGraphLevel=3` does not trigger any failure.

This pull request has now been integrated.

Changeset: 97f1321c
Author:    Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/97f1321cb455b536f1e4e056dec693c24f39d641
Stats:     18 lines in 1 file changed: 4 ins; 7 del; 7 mod

8294356: IGV: scheduled graphs contain duplicated elements

Reviewed-by: chagedorn, thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/10423


More information about the hotspot-compiler-dev mailing list