RFR: 8280378: [IR Framework] Support IR matching for different compile phases

Christian Hagedorn chagedorn at openjdk.org
Tue Oct 18 15:18:42 UTC 2022


On Mon, 17 Oct 2022 08:15:11 GMT, Hao Sun <haosun at openjdk.org> wrote:

> Hi,
> 
> 1. For the following two files, the copyright year should be updated to 2022.
> 
> ```
> src/hotspot/share/opto/phasetype.hpp
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/FlagVMProcess.java
> ```

Good catch! I've updated them.

> 2. I tested this PR on one SVE supporting machine and found the IR verification failed for the following 4 cases. Mainly because the IR nodes are not created for these SVE related rules.
> 
> ```
> test/hotspot/jtreg/compiler/vectorapi/AllBitsSetVectorMatchRuleTest.java
> test/hotspot/jtreg/compiler/vectorapi/VectorFusedMultiplyAddSubTest.java
> test/hotspot/jtreg/compiler/vectorapi/VectorGatherScatterTest.java
> test/hotspot/jtreg/compiler/vectorapi/VectorMaskedNotTest.java
> ```

Thanks a lot Hao for running additional testing to catch these missing test updates which our CI testing did not cover. The patch looks good, thanks for providing the required updates! I've pushed the changes.

-------------

PR: https://git.openjdk.org/jdk/pull/10695


More information about the hotspot-compiler-dev mailing list