RFR: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

[Christian Hagedorn]

On Tue, 18 Oct 2022 18:52:43 GMT, Dean Long <dlong at openjdk.org> wrote:

> The "bad AD file" error is because PartialSubtypeCheck produces an iRegP_R5 result, which cannot be matched as an input where iRegP is expected.
> Update the test to reproduce the crash and updated iRegP rule to match iRegP_R5.
> The fact that this went so long without being noticed makes me wonder how much test coverage PartialSubtypeCheck has received on aarch64.

Otherwise, looks good!

test/hotspot/jtreg/compiler/types/TestSubTypeCheckMacroTrichotomy.java line 33:

> 31:  *
> 32:  * @run main/othervm -XX:-BackgroundCompilation TestSubTypeCheckMacroTrichotomy
> 33:  * @run main/othervm -XX:-BackgroundCompilation -XX:+StressReflectiveCode -XX:+ExpandSubTypeCheckAtParseTime

You should additionally add `-XX:+UnlockDiagnosticVMOptions` since `ExpandSubTypeCheckAtParseTime` is a diagnostic VM flag.

-------------

Changes requested by chagedorn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10749