RFR: JDK-8290011: IGV: Remove dead code and cleanup [v22]
Tobias Holenstein
tholenstein at openjdk.org
Wed Oct 19 14:01:48 UTC 2022
> Cleanup of the code in IGV without changing the functionality.
>
> - removed dead code (unused classes, functions, variables) from the IGV code base
> - merged (and removed) redundant functions
> - added explicit position arguments to `layer.xml` - This avoids the position warning during building of IGV
> - ordered the inputs alphabetically, and used wildcards if >= 5 imports of a particular package
> - made class variables `final` whenever possible
> - removed `this.` in `this.funtion()` funciton calls when it was not needed
> - used lambdas instead of anonymous class if possible
> - fixed whitespace issues (e.g. double whitespace)
> - removed not needed copy of `RangeSliderModel tempModel` in `RangeSliderModel.java`
> - changed `EditorTopComponent` to take `InputGraph` as argument in constructor instead of `Diagram` and moved the creation of the `Diagram` to `DiagramViewModel.java` to increased encapsulation/modularity
Tobias Holenstein has updated the pull request incrementally with five additional commits since the last revision:
- Merge branch 'JDK-8290011' of github.com:tobiasholenstein/jdk into JDK-8290011
- inline SIZE
Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
- remove setUndoRedoEnabled() and getUndoRedoEnabled()
- remove getScrollPane()
- inline SIZE
Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10197/files
- new: https://git.openjdk.org/jdk/pull/10197/files/6f2111e2..d30d693b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10197&range=21
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10197&range=20-21
Stats: 53 lines in 3 files changed: 4 ins; 21 del; 28 mod
Patch: https://git.openjdk.org/jdk/pull/10197.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10197/head:pull/10197
PR: https://git.openjdk.org/jdk/pull/10197
More information about the hotspot-compiler-dev
mailing list