RFR: JDK-8290011: IGV: Remove dead code and cleanup [v20]

[Tobias Holenstein]

On Wed, 19 Oct 2022 12:17:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   re-add ConnectionSet class
>>   
>>   is needed to highlight hovered edges
>
> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/ClusterOutputSlotNode.java line 106:
> 
>> 104:     public Dimension getSize() {
>> 105:         int SIZE = 0;
>> 106:         return new Dimension(SIZE, SIZE);
> 
> Suggestion:
> 
>         return new Dimension(0, 0);

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramScene.java line 466:
> 
>> 464:     private JScrollPane getScrollPane() {
>> 465:         return scrollPane;
>> 466:     }
> 
> You could directly replace the usages of `getScrollPane()` inside this class by a field access to `scrollPane`.

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramScene.java line 1245:
> 
>> 1243:     private boolean getUndoRedoEnabled() {
>> 1244:         return undoRedoEnabled;
>> 1245:     }
> 
> You could directly modify the field instead of going over the private setter/getter.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10197