Integrated: JDK-8290011: IGV: Remove dead code and cleanup
Tobias Holenstein
tholenstein at openjdk.org
Wed Oct 19 15:53:11 UTC 2022
On Wed, 7 Sep 2022 11:45:45 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
> Cleanup of the code in IGV without changing the functionality.
>
> - removed dead code (unused classes, functions, variables) from the IGV code base
> - merged (and removed) redundant functions
> - added explicit position arguments to `layer.xml` - This avoids the position warning during building of IGV
> - ordered the inputs alphabetically, and used wildcards if >= 5 imports of a particular package
> - made class variables `final` whenever possible
> - removed `this.` in `this.funtion()` funciton calls when it was not needed
> - used lambdas instead of anonymous class if possible
> - fixed whitespace issues (e.g. double whitespace)
> - removed not needed copy of `RangeSliderModel tempModel` in `RangeSliderModel.java`
> - changed `EditorTopComponent` to take `InputGraph` as argument in constructor instead of `Diagram` and moved the creation of the `Diagram` to `DiagramViewModel.java` to increased encapsulation/modularity
This pull request has now been integrated.
Changeset: e27bea0c
Author: Tobias Holenstein <tholenstein at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e27bea0c4db282e26d0d96611bb330e02c314d48
Stats: 4529 lines in 133 files changed: 340 ins; 3375 del; 814 mod
8290011: IGV: Remove dead code and cleanup
Reviewed-by: chagedorn
-------------
PR: https://git.openjdk.org/jdk/pull/10197
More information about the hotspot-compiler-dev
mailing list