Integrated: JDK-8294565: IGV: ClassCastException when clicking on an edge in the graph

Tobias Holenstein tholenstein at openjdk.org
Mon Oct 24 14:20:58 UTC 2022


On Wed, 19 Oct 2022 11:13:35 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> IGV crashed when the user clicked on any edge in the graph because the `select` method of the `SelectProvider` in `LineWidget.java` was faulty. 
> 
> # Implementation
> - `ActionFactory.createSelectAction` was changed to `CustomSelectAction` since it also supports to invert the selection with `Ctrl/CMD`
> - The `select` method gets called when the user clicks on an edge. `LineWidget` represents a single connection going out of a node and connecting to one or more nodes (one-to-many). `LineWidget` has a list of `Connection`'s that each represent a single link between two nodes (one-to-one). For each `connection` we collect the from/to `Vertex` (superclass for a node) and put them into a set that we then use to select the nodes that are connected to the user-clicked `LineWidget`.

This pull request has now been integrated.

Changeset: c055dfc3
Author:    Tobias Holenstein <tholenstein at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c055dfc3ce5fe1cdc3e1a0d5a182df355a40c6b7
Stats:     88 lines in 2 files changed: 18 ins; 15 del; 55 mod

8294565: IGV: ClassCastException when clicking on an edge in the graph

Reviewed-by: rcastanedalo, thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/10760


More information about the hotspot-compiler-dev mailing list