RFR: 8291336: Add ideal rule to convert floating point multiply by 2 into addition [v4]

SuperCoder79 duke at openjdk.org
Mon Oct 24 18:28:09 UTC 2022


On Tue, 27 Sep 2022 18:42:10 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> SuperCoder79 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply style changes from code review
>
> src/hotspot/share/opto/mulnode.cpp line 438:
> 
>> 436: //------------------------------Ideal---------------------------------------
>> 437: // Check to see if we are multiplying by a constant 2 and convert to add, then try the regular MulNode::Ideal
>> 438: Node *MulFNode::Ideal(PhaseGVN *phase, bool can_reshape) {
> 
> Please use the format `Type* identifier` for new code (in this case it is `PhaseGVN* phase`). The same applies to other places.

Done

> test/hotspot/jtreg/compiler/c2/irTests/TestMulNodeIdealization.java line 61:
> 
>> 59:     @Run(test = "testFloat")
>> 60:     public void runTestFloat() {
>> 61:         testFloat(RANDOM.nextFloat());
> 
> Verification against the execution in the interpreter would be better here.

Completed, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/9642


More information about the hotspot-compiler-dev mailing list