RFR: JDK-8265441: IGV: select block nodes by clicking on it

Tobias Holenstein tholenstein at openjdk.org
Wed Oct 26 07:56:26 UTC 2022


On Wed, 26 Oct 2022 05:34:04 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> Should un-select by double clicking on a block that has selected nodes also work?

Hi @TobiHartmann 
Thanks for suggestion! 

I decided to leave this out for the following reason:
- What happens if some of the nodes in e.g. B10 are selected by double-clicking? Either unselect them all or select them all. If a user double-clicks on a node and then node by node unselects them all - When now double clicking again, should we select or unselect all? The user probably expects that all nodes get selected since all are unselected, but the "select state" of the block would still be selected from the last double-click. Of course we could update the block state for every change in selection that we make. But I think it makes things complicated. 
Another option would be to always invert the selection (like with the rectangle selection), but I don't think this is very intuitive for the user. 

My suggestion is to leave this out for the moment. If desired it can still be introduced in the future.

-------------

PR: https://git.openjdk.org/jdk/pull/10854


More information about the hotspot-compiler-dev mailing list