RFR: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic [v3]

Xiaolin Zheng xlinzheng at openjdk.org
Fri Oct 28 03:53:29 UTC 2022


On Thu, 27 Oct 2022 12:33:13 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Maybe a license
>
> test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java line 57:
> 
>> 55: 
>> 56:     static void proofread(double ans) {
>> 57:         if (Math.abs(ans - expected) > 1e8) {
> 
> If we want to do equivalence check here, shouldn't we compare with 1e-8 instead of 1e8?
> That said, do we really need this "proofread" check? I am assuming the check at line #80 is sufficient for this issue.

Sorry for the error - yes, it should have been `1e-8`, but somehow the `-` ran away when it was written :-).
And yes again: only the former check matters, so it is removed.

-------------

PR: https://git.openjdk.org/jdk/pull/10867


More information about the hotspot-compiler-dev mailing list