RFR: 8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes [v4]
Doug Simon
dnsimon at openjdk.org
Fri Oct 28 10:16:19 UTC 2022
On Fri, 28 Oct 2022 10:03:46 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> 8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>
> arm32 fix
Marked as reviewed by dnsimon (Committer).
src/hotspot/share/asm/codeBuffer.hpp line 457:
> 455: _stubs.initialize_outer(this, SECT_STUBS);
> 456:
> 457: // default value. should be changed if vectorization requires large aligned constants
I would not make this comment so vectorization specific. Just say something like:
// Default is to align on 8 bytes. A compiler can change this
// if larger alignment (e.g., 32-byte vector masks) is required.
-------------
PR: https://git.openjdk.org/jdk/pull/10392
More information about the hotspot-compiler-dev
mailing list