RFR: 8292301: [REDO v2] C2 crash when allocating array of size too large

Roland Westrelin roland at openjdk.org
Thu Sep 1 13:29:12 UTC 2022


On Wed, 31 Aug 2022 08:07:06 GMT, Xin Liu <xliu at openjdk.org> wrote:

> the two bugfixes work for me. LGTM. I am not a reviewer. need other reviewers to approve it.

Thanks for reviewing this.

> src/hotspot/share/opto/phaseX.cpp line 1855:
> 
>> 1853: // Same if true if the type of a ValidLengthTest input to an AllocateArrayNode changes
>> 1854: void PhaseCCP::push_catch(Unique_Node_List& worklist, const Node* use) {
>> 1855:   if (use->is_Call() || use->is_AllocateArray()) {
> 
> hi, Roland, 
> I understand your intention here, but isn't AllocateArrayNode also a CallNode? 
> My understanding is that use->is_Call() is true if use is an AllocationNode.

Good catch. There's no issue with CCP then. I'll update the change.

-------------

PR: https://git.openjdk.org/jdk/pull/10038


More information about the hotspot-compiler-dev mailing list