RFR: 8288897: Clean up node dump code [v5]

[Emanuel Peter]

On Fri, 12 Aug 2022 08:14:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8288897
>>  - review suggestions from @navyxliu
>>  - implementing Christians review suggestions
>>  - Merge branch 'master' into JDK-8288897
>>  - Apply suggestions from code review
>>    
>>    2 style fixes by Christian
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - cleanup, move debug functions to cpp to prevent inlining, add comment for debugger functions
>>  - make dump_bfs const, change datastructures, change some signatures to const
>>  - refactor dump to use dump_bfs, redefine categories through output types
>>  - 8288897: Clean up dump code for nodes
>
> I was out on vacation and only had the chance to have a look it again now. Thanks for doing the updates and verifying that the order is still the same! Thanks @navyxliu for double checking it as well! The colorful dump looks really nice :)
> 
> Thanks,
> Christian

Thanks @chhagedorn @navyxliu for the review and comments!

-------------

PR: https://git.openjdk.org/jdk/pull/9234