Integrated: 8288897: Clean up node dump code

[Emanuel Peter]

On Wed, 22 Jun 2022 11:38:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> I recently did some work in the area of `Node::dump` and `Node::find`, see [JDK-8287647](https://bugs.openjdk.org/browse/JDK-8287647) and [JDK-8283775](https://bugs.openjdk.org/browse/JDK-8283775).
> 
> This change sets cleans up the code around, and tries to reduce code duplication.
> 
> Things I did:
> - remove Node::related. It was added 7 years ago, with [JDK-8004073](https://bugs.openjdk.org/browse/JDK-8004073). However, it was not extended to many nodes, and hence it is incomplete, and nobody I know seems to use it.
> - refactor `dump(int)` to use `dump_bfs` (reduce code duplication).
> - redefine categories in `dump_bfs`, focusing on output types. Mixed type is now also control if it has control output, and memory if it has memory output, etc. Plus, a node is also in the control category if it `is_CFG`. This makes `dump_bfs` much more usable, to traverse control and memory flow.
> - Other small cleanups, like replacing rarely used dump functions with dump, making removing dead code, make some functions private
> - Adding `call from debugger` comment to VM functions that are useful in debugger
> - rename `find_node_by_name` to `find_nodes_by_name` and `find_node_by_dump` to `find_nodes_by_dump`.
> - remove now unused dump indent compiler flag `PrintIdealIndentThreshold` (notproduct)

This pull request has now been integrated.

Changeset: dbb2c4b6
Author:    Emanuel Peter <epeter at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dbb2c4b6ac01d2a3367a2354213d3b4230dfbb96
Stats:     683 lines in 18 files changed: 53 ins; 554 del; 76 mod

8288897: Clean up node dump code

Reviewed-by: chagedorn, xliu

-------------

PR: https://git.openjdk.org/jdk/pull/9234