RFR: 8293497: Build failure due to MaxVectorSize was not declared when C2 is disabled after JDK-8293254

Dean Long dlong at openjdk.org
Thu Sep 8 02:17:43 UTC 2022


On Wed, 7 Sep 2022 23:01:32 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 38:
>> 
>>> 36: #if INCLUDE_JVMCI
>>> 37: #include "jvmci/jvmci_globals.hpp"
>>> 38: #endif
>> 
>> Shouldn't that be "utilities/macros.hpp" to pick up the COMPILER2_OR_JVMCI macro?
>
>> Shouldn't that be "utilities/macros.hpp" to pick up the COMPILER2_OR_JVMCI macro?
> 
> Thanks @dean-long for the review.
> 
> You mean we should fix it like this?
> 
> diff --git a/src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp b/src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp
> index b08e1f7..1d149c0 100644
> --- a/src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp
> +++ b/src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp
> @@ -30,6 +30,7 @@
>  #include "runtime/sharedRuntime.hpp"
>  #include "runtime/stubRoutines.hpp"
>  #include "stubGenerator_x86_64.hpp"
> +#include "utilities/macros.hpp"
>  #ifdef COMPILER2
>  #include "opto/c2_globals.hpp"
>  #endif
> 
> 
> But it won't fix it actually.

OK.  Sorry, I misunderstood the problem.

-------------

PR: https://git.openjdk.org/jdk/pull/10202


More information about the hotspot-compiler-dev mailing list