RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Sep 8 12:59:39 UTC 2022
On Thu, 8 Sep 2022 12:40:33 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> The `BytecodeViewTopComponent` and `ControlFlowTopComponent` represent information depending on what graph is open in `EditorTopComponent`. Previously, `BytecodeViewTopComponent` and `ControlFlowTopComponent` did not update its content immediately when a new graph from a different group is opened in `EditorTopComponent`. They also did not update when switching between two tabs of open graph.
>>
>> We missed to `fire()` a `diagramChangedEvent` in the constructor of `EditorTopComponent`. We also need to fire when `BytecodeViewTopComponent` and `ControlFlowTopComponent` are initially opened.
>> <img width="1291" alt="Update" src="https://user-images.githubusercontent.com/71546117/188860123-825a67fd-aab3-4500-8a47-8fa56eb9aeed.png">
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>
> use multi-line lambdas
Marked as reviewed by rcastanedalo (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/10196
More information about the hotspot-compiler-dev
mailing list