RFR: 8292761: x86: Clone nodes to match complex rules [v2]

[Quan Anh Mai]

On Fri, 9 Sep 2022 10:09:17 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into cloneSimpleNodes
>>  - fix
>>  - Merge branch 'master' into cloneSimpleNodes
>>  - shorten
>>  - improve checks
>>  - lea patterns
>>  - refactor
>>  - lea patterns
>>  - first commit
>
> Please include the benchmark in the patch. Could you show the generated code before/after? Thanks!

@TobiHartmann Thanks a lot for your review, I have added the benchmark to the patch, the generated code is as follow:

    CloneNodes::testAndn:
    Baseline:
    movl    $0xffffffff, %r8d
    xorl    0x20(%rbx,%r11,4), %r8d
    movl    %r8d, %r9d
    andl    %edi, %r9d
    andl    %ecx, %r8d

    Patched:
    movl    0x10(%rdi,%r11,4), %r10d
    andnl   %ebx, %r10d, %r9d
    andnl   %ecx, %r10d, %r8d


    CloneNodes::testLea:
    Baseline:
    movl    0x14(%rdi,%r11,4), %r8d
    shll    $0x2, %r8d
    movl    %r8d, %r9d
    addl    $0x7, %r9d
    addl    $0x3, %r8d

    Patched:
    movl    0x10(%rcx,%r11,4), %r10d
    leal    0x3(,%r10,4), %r9d
    leal    0x7(,%r10,4), %r10d

-------------

PR: https://git.openjdk.org/jdk/pull/9977