RFR: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127 [v3]

[Roland Westrelin]

On Thu, 8 Sep 2022 06:46:28 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Christian's review
>>  - Merge branch 'master' into JDK-8291599
>>  - Update test/hotspot/jtreg/compiler/loopopts/TestPhiInSkeletonPredicateExpression.java
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopTransform.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - fix
>>  - test
>
> test/hotspot/jtreg/compiler/loopopts/TestPhiInSkeletonPredicateExpression.java line 28:
> 
>> 26:  * bug 8291599
>> 27:  * @summary Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
>> 28:  * @run main/othervm -XX:-TieredCompilation -XX:-BackgroundCompilation -XX:-UseOnStackReplacement -XX:LoopMaxUnroll=0 TestPhiInSkeletonPredicateExpression
> 
> Since `LoopMaxUnroll` is a C2 flag, we should also add a `@requires vm.compiler2.enabled`.

Thanks for the review. I made the changes that you suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/10022