RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v4]

Tobias Holenstein tholenstein at openjdk.org
Fri Sep 9 13:10:59 UTC 2022


> The `BytecodeViewTopComponent` and `ControlFlowTopComponent` represent information depending on what graph is open in `EditorTopComponent`. Previously, `BytecodeViewTopComponent` and `ControlFlowTopComponent` did not update its content immediately when a new graph from a different group is opened in `EditorTopComponent`. They also did not update when switching between two tabs of open graph. 
> 
> We missed to `fire()` a `diagramChangedEvent` in the constructor of `EditorTopComponent`. We also need to fire when `BytecodeViewTopComponent` and `ControlFlowTopComponent` are initially opened. 
> <img width="1291" alt="Update" src="https://user-images.githubusercontent.com/71546117/188860123-825a67fd-aab3-4500-8a47-8fa56eb9aeed.png">

Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:

  Update Bytecode and ControlFlow when a group is removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10196/files
  - new: https://git.openjdk.org/jdk/pull/10196/files/49dbaa31..e9088043

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=02-03

  Stats: 60 lines in 7 files changed: 27 ins; 29 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/10196.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10196/head:pull/10196

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list