RFR: 8293654: Improve SharedRuntime handling of continuation helper out-arguments [v2]

Aleksey Shipilev shade at openjdk.org
Tue Sep 13 07:15:52 UTC 2022


On Tue, 13 Sep 2022 06:35:33 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrap in ASSERT
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 1611:
> 
>> 1609:     }
>> 1610: 
>> 1611:     if (method->is_continuation_enter_intrinsic()) {
> 
> I suggest putting these if's inside an #ifdef ASSERT.  Or if you don't mind breaking up the asserts, move them up into the if's above.

Done the `#ifdef ASSERT` thing in new commit.

-------------

PR: https://git.openjdk.org/jdk/pull/10241


More information about the hotspot-compiler-dev mailing list