Integrated: 8293774: Improve TraceOptoParse to dump the bytecode name

Jie Fu jiefu at openjdk.org
Wed Sep 14 07:21:08 UTC 2022


On Wed, 14 Sep 2022 04:06:58 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> Please review this one-line patch which prints the bytecode name for `TraceOptoParse`.
> 
> While I was debugging with `TraceOptoParse`, I found it only prints the bci without the bytecode name.
> I had to map the bci to the bytecode manually again and again.
> It would be better to also dump the bytecode name.
> 
> Before:
> 
>     568  503       4       jdk.internal.org.objectweb.asm.ByteVector::putUTF8 (144 bytes)
> Merging state at block #0 bci:0 with empty state on path 1
> Parsing block #0 at bci [0,11), successors:  1 2
>  @ bci:0
>  @ bci:1
> Uncommon trap reason='null_check' action='maybe_recompile' debug_id='0' at bci:1
> Merging state at block #0 bci:0 with empty state on path 1
> Parsing block #0 at bci [0,11), successors:
>  @ bci:0
>  @ bci:1
>  @ bci:4
> Uncommon trap reason='null_check' action='maybe_recompile' debug_id='0' at bci:4
>  @ bci:5
>  @ bci:6
> Merging state at block #0 bci:0 with empty state on path 1
> 
> 
> After:
> 
>     571  507       4       jdk.internal.org.objectweb.asm.ByteVector::putUTF8 (144 bytes)
> Merging state at block #0 bci:0 with empty state on path 1
> Parsing block #0 at bci [0,11), successors:  1 2
>  @ bci:0 aload_1
>  @ bci:1 invokevirtual
> Uncommon trap reason='null_check' action='maybe_recompile' debug_id='0' at bci:1
> Merging state at block #0 bci:0 with empty state on path 1
> Parsing block #0 at bci [0,11), successors:
>  @ bci:0 aload_0
>  @ bci:1 getfield
>  @ bci:4 arraylength
> Uncommon trap reason='null_check' action='maybe_recompile' debug_id='0' at bci:4
>  @ bci:5 aload_0
>  @ bci:6 invokevirtual
> Merging state at block #0 bci:0 with empty state on path 1
> 
> 
> Testing:
>  - tier1~3 on Linux/x64 in progress, seems fine until now
> 
> Thanks.
> Best regards,
> Jie

This pull request has now been integrated.

Changeset: 91f9c0d0
Author:    Jie Fu <jiefu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/91f9c0d0cfd3d328aaec05254925d1b15611cd6e
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8293774: Improve TraceOptoParse to dump the bytecode name

Reviewed-by: chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/10262


More information about the hotspot-compiler-dev mailing list