RFR: 8292761: x86: Clone nodes to match complex rules [v3]
Tobias Hartmann
thartmann at openjdk.org
Wed Sep 14 12:25:37 UTC 2022
On Fri, 9 Sep 2022 11:18:50 GMT, Quan Anh Mai <duke at openjdk.org> wrote:
>> Hi,
>>
>> This patch tries to clone a node if it can be matched as a part of a BMI and lea pattern. This may reduce the live range of a local or remove that local completely.
>>
>> Please take a look and have some reviews. Thanks a lot.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>
> - add benchmark
> - Merge branch 'master' into cloneSimpleNodes
> - Merge branch 'master' into cloneSimpleNodes
> - fix
> - Merge branch 'master' into cloneSimpleNodes
> - shorten
> - improve checks
> - lea patterns
> - refactor
> - lea patterns
> - ... and 1 more: https://git.openjdk.org/jdk/compare/3e8a2f56...0beae979
Thanks. This looks reasonable to me but please add comments explaining the individual patterns with an example.
Someone more familiar with this code (@jatin-bhateja, @sviswa7 ?), should also have a look.
-------------
PR: https://git.openjdk.org/jdk/pull/9977
More information about the hotspot-compiler-dev
mailing list