RFR: 8291600: [vectorapi] vector cast op check is not always needed for vector mask cast [v7]

Xiaohong Gong xgong at openjdk.org
Thu Sep 15 08:41:49 UTC 2022


On Thu, 15 Sep 2022 08:22:11 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Yeah, agree to you. Or maybe as assert under `if(num_elem_from < num_elem_to)` and `if(num_elem_from > num_elem_to)` ?  I'm sorry that I didn't find a better place to add the comment. Any suggestions? For me, it's better to add the comment inside the `if(is_cast)` block since it has different paths based on the `num_elem_from` and `num_elem_to`.
>
> Something like: `assert(!is_mask, "mask cast needs the same elem num ")`

Hi, I'd like the add the assertion in the unify patch instead of this. So I will revert this change here. Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/9737


More information about the hotspot-compiler-dev mailing list