Integrated: 8291600: [vectorapi] vector cast op check is not always needed for vector mask cast

[Xiaohong Gong]

On Thu, 4 Aug 2022 06:08:44 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

> Recently we found the performance of "`FIRST_NONZERO`" for double type is largely worse than the other types on x86 when `UseAVX=2`. The main reason is the "`VectorCastL2X`" op is not supported by the backend when the dst element type is `T_DOUBLE`. This makes the check of `VectorCast` op fail before intrinsifying "`VectorMask.cast()`" which is used in the
> "`FIRST_NONZERO`" java implementation (see [1]). However, the compiler will not generate the `VectorCast `op for `VectorMask.cast()` if:
> 
>  1) the current platform supports the predicated feature
>  2) the element size (in bytes) of the src and dst type is the same
> 
> So the check of "`VectorCast`" op is needless for such cases. To fix it, this patch:
> 
>  1) limits the specified vector cast op check to vectors
>  2) adds the relative mask cast op check for VectorMask.cast()
>  3) cleans up the unnecessary codes
> 
> Here is the performance of "`FIRST_NONZERO`" benchmark [2] on a x86 machine with `UseAVX=2`:
> 
> Benchmark                          (size) Mode Cnt Before  After   Units
> DoubleMaxVector.FIRST_NONZERO       1024  thrpt 15 49.266 2460.886 ops/ms
> DoubleMaxVector.FIRST_NONZEROMasked 1024  thrpt 15 49.554 1892.223 ops/ms
> 
> [1] https://github.com/openjdk/jdk/blob/master/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java#L770
> [2] https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/micro/org/openjdk/bench/jdk/incubator/vector/operation/DoubleMaxVector.java#L246

This pull request has now been integrated.

Changeset: 3beca2db
Author:    Xiaohong Gong <xgong at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3beca2db0761f8172614bf1b287b694c8595b498
Stats:     18 lines in 1 file changed: 7 ins; 3 del; 8 mod

8291600: [vectorapi] vector cast op check is not always needed for vector mask cast

Co-authored-by: Quan Anh Mai <qamai at openjdk.org>
Reviewed-by: jiefu, eliu, jbhateja

-------------

PR: https://git.openjdk.org/jdk/pull/9737