RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v6]
Tobias Holenstein
tholenstein at openjdk.org
Fri Sep 16 14:58:04 UTC 2022
> The `BytecodeViewTopComponent` and `ControlFlowTopComponent` represent information depending on what graph is open in `EditorTopComponent`. Previously, `BytecodeViewTopComponent` and `ControlFlowTopComponent` did not update its content immediately when a new graph from a different group is opened in `EditorTopComponent`. They also did not update when switching between two tabs of open graph.
>
> We missed to `fire()` a `diagramChangedEvent` in the constructor of `EditorTopComponent`. We also need to fire when `BytecodeViewTopComponent` and `ControlFlowTopComponent` are initially opened.
> <img width="1291" alt="Update" src="https://user-images.githubusercontent.com/71546117/188860123-825a67fd-aab3-4500-8a47-8fa56eb9aeed.png">
Tobias Holenstein has updated the pull request incrementally with four additional commits since the last revision:
- Fix for: parent is null for DiffGraph
- remove DiagramProvider
- add ChangedListener to LookupHistory
- update OutlineTopComponent graph closed
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10196/files
- new: https://git.openjdk.org/jdk/pull/10196/files/2a643165..31b9d673
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=04-05
Stats: 399 lines in 11 files changed: 134 ins; 200 del; 65 mod
Patch: https://git.openjdk.org/jdk/pull/10196.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10196/head:pull/10196
PR: https://git.openjdk.org/jdk/pull/10196
More information about the hotspot-compiler-dev
mailing list