RFR: JDK-8293364: IGV: Refactor Action in EditorTopComponent and fix minor bugs [v5]

[Tobias Holenstein]

On Fri, 16 Sep 2022 12:41:16 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Tobias Holenstein has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - Update Copyright year
>>  - Update OutlineTopComponent.java
>>    
>>    Revert "Update OutlineTopComponent.java"
>>    
>>    This reverts commit 65e0651730983e12c032bb89564c3ef93aa34dbe.
>>    
>>    revert whitespace change
>
> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/actions/ImportAction.java line 52:
> 
>> 50: import org.openide.util.RequestProcessor;
>> 51: import org.openide.util.Utilities;
>> 52: import org.openide.util.actions.CallableSystemAction;
> 
> As discussed earlier, it would really be preferable to leave cleanups of this kind to a separate RFE, especially if the file is not changed otherwise. It would make reviewing easier, especially on large changesets like this one. Why not postpone all import reordering to https://github.com/openjdk/jdk/pull/10197? Similarly for e.g. the changes in `DiagramScene.java`.

I agree, if the file is not touched, imports should not be modified. Hopefully after https://github.com/openjdk/jdk/pull/10197 this mistake shouldn't happen anymore :)

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/EditorTopComponent.java line 431:
> 
>> 429:         setLayout(new java.awt.BorderLayout());
>> 430: 
>> 431:     }// </editor-fold>//GEN-END:initComponents
> 
> Did you check whether, after moving this generated code, it can still be updated using NetBeans' Form Editor?

I reverted the change. The NetBeans' Form Editor opens it, but just shows an empty plane. I don't really know why there is an `JCheckBox jCheckBox1` if we don't use it. But let's just leave it the way NetBeans generated it.

-------------

PR: https://git.openjdk.org/jdk/pull/10170