RFR: JDK-8290011: IGV: Remove dead code and cleanup [v4]

[Tobias Holenstein]

On Thu, 8 Sep 2022 08:12:46 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/EditorTopComponent.java
>>   
>>   remove whitespace
>>   
>>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> src/utils/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/InputNode.java line 36:
> 
>> 34:     private int id;
>> 35: 
>> 36:     public static final Comparator<InputNode> COMPARATOR = new Comparator<InputNode>() {
> 
> Is unused as well and can be removed. Same for `getPropertyComparator()`.

you are right! done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramViewModel.java line 92:
> 
>> 90:         boolean viewPropertiesChanged = false;
>> 91: 
>> 92:         boolean groupChanged = (group != newModel.group);
> 
> Was that a bug?

Yes, it didn't cause any crashes or wrong behaviour as far is I can tell. But from looking at the code, it makes sense that it should be `!=`  for `groupChanged` to be true

-------------

PR: https://git.openjdk.org/jdk/pull/10197