RFR: JDK-8293978: Duplicate simple loop back-edge will crash the vm [v2]

王超 duke at openjdk.org
Mon Sep 19 08:40:02 UTC 2022


On Mon, 19 Sep 2022 07:56:39 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> 王超 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move the condition ahead
>
> src/hotspot/share/opto/loopopts.cpp line 3972:
> 
>> 3970:   }
>> 3971: 
>> 3972:   if (idom(region)->is_Catch() || region == head) {
> 
> That check could be done earlier I think at the test for:
>  `if (!incr->is_Phi()) {`

Thank your for the suggestion! I have move the check to `if (!incr->is_Phi())`

-------------

PR: https://git.openjdk.org/jdk/pull/10329


More information about the hotspot-compiler-dev mailing list