RFR: 8294014: Remove redundant UseCompiler conditions

xiaomi duke at openjdk.org
Mon Sep 19 15:11:52 UTC 2022


On Mon, 19 Sep 2022 13:57:05 GMT, xiaomi <duke at openjdk.org> wrote:

>> Several areas that use CompileBroker::should_compile_new_jobs() also contain a UseCompiler check which isn't needed, since the aforementioned already contains a check for this flag. In some areas (Such as with compileBroker.cpp which has AlwaysCompileLoopMethods) this duplicated check is required, so we can mark should_compile_new_jobs() and the related get_compilation_activity_mode() as inline to make the obvious optimization more obvious to the compiler used in the build (This should be fine, since both are small methods).
>
> hello, What does the sequence of numbers at the beginning of the title mean? :) How do I get my own sequence of numbers as a pr title? tks ;)

> Hey @mizhitian-xiaomi,
> 
> The numbers at the start of the title are the id of the entry in the JDK tracker (This particular one is https://bugs.openjdk.org/browse/JDK-8294014), you do unfortunately need to be an Author to access this tracker though. The upside is that doing so only requires that you have 2 Pull Requests that are already accepted to apply as an Author, so for your first 2 changesets you'd need to ask someone else to help you create entries in the tracker, and you should be good from there onwards. Your message being removed like that does mean you haven't signed the contributor agreement though, which you can do so here: https://oca.opensource.oracle.com/
> 
> (It's frustrating I know, hopefully you'll have the patience to sit through the long approval process)




Thanks for your help~

-------------

PR: https://git.openjdk.org/jdk/pull/10342


More information about the hotspot-compiler-dev mailing list