RFR: JDK-8293364: IGV: Refactor Action in EditorTopComponent and fix minor bugs [v8]

Tobias Holenstein tholenstein at openjdk.org
Mon Sep 19 15:29:21 UTC 2022


On Mon, 19 Sep 2022 08:56:44 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   undo removing variable generated by form editor
>
> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/EnableBlockLayoutAction.java line 40:
> 
>> 38:  * @author Thomas Wuerthinger
>> 39:  */
>> 40: public class EnableBlockLayoutAction extends AbstractAction implements PropertyChangeListener {
> 
> `EnableBlockLayoutAction`, `EnableCFGLayoutAction` and `EnableSeaLayoutAction` are very similar and could share some code. You could add a super class `EnableLayoutAction` (or any other name that fits) for them and put everything that's shared into it.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10170


More information about the hotspot-compiler-dev mailing list